go
/
isokit
Watch 1
Star 1
Fork 0
Code Issues 0 Pull Requests 1 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#1 Fixing route and router to allow for multiple variables in path.

Open
antonienko wants to merge 0 commits from deleted into master
Conversation 0 Commits N/A Files changed N/A
antonienko commented 6 years ago

On the isokit/router, it was not possible to have multiple variables in a path.

With this patch it is possible, but the format of the key to retrieve the variables change. Instead of having to type the whole path as the key, is just the variable name, similar to what gorilla/mux does.

I'm afraid this breaks backwards compatibility, but I'm confident this was the intended way for it to work.

I have added some unit tests to the route file, but didn't have the time to create a test for the router modification, since it's a way more complex test case.

On the isokit/router, it was not possible to have multiple variables in a path. With this patch it is possible, but the format of the key to retrieve the variables change. Instead of having to type the whole path as the key, is just the variable name, similar to what gorilla/mux does. I'm afraid this breaks backwards compatibility, but I'm confident this was the intended way for it to work. I have added some unit tests to the route file, but didn't have the time to create a test for the router modification, since it's a way more complex test case.
Data of this pull request has been broken due to deletion of fork information.
Sign in to join this conversation.
Labels
Clear labels
No Label
Milestone
Clear milestone
No Milestone
Assignee
Clear assignee
No assignee
1 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.
Delete Branch deleted

Deleting a branch is permanent. There is no way to undo it.

- This operation CANNOT be undone.
- This operation will permanently delete everything in branch deleted.
No
Yes